summaryrefslogtreecommitdiff
path: root/src/matrixOperations
diff options
context:
space:
mode:
Diffstat (limited to 'src/matrixOperations')
-rw-r--r--src/matrixOperations/chol/cchola.c7
-rw-r--r--src/matrixOperations/chol/testDoubleChol.c83
-rw-r--r--src/matrixOperations/chol/zchola.c12
3 files changed, 79 insertions, 23 deletions
diff --git a/src/matrixOperations/chol/cchola.c b/src/matrixOperations/chol/cchola.c
index 4ebf473e..0de211be 100644
--- a/src/matrixOperations/chol/cchola.c
+++ b/src/matrixOperations/chol/cchola.c
@@ -77,6 +77,13 @@ void cchola(floatComplex * in, int size, floatComplex *out){
tmp = FloatComplex(creals(in[i*size+i])-accu,0);
out[i*size+i]=csqrts(tmp);
}
+
+ /*Zeros in the lower triangular part*/
+ for (i=0;i<size;i++){
+ for (j=i+1;j<size;j++){
+ out[j+i*size]=FloatComplex(0,0);
+ }
+ }
#endif
}
diff --git a/src/matrixOperations/chol/testDoubleChol.c b/src/matrixOperations/chol/testDoubleChol.c
index aecd97db..58754a8b 100644
--- a/src/matrixOperations/chol/testDoubleChol.c
+++ b/src/matrixOperations/chol/testDoubleChol.c
@@ -17,17 +17,20 @@
#include <math.h>
#include <malloc.h>
+/* FIXME : assert à 1e-14 pour une valeur d'entrée de 0.003... */
+
static void dcholsTest(void){
double in=4;
double out;
printf("\n >>> DCholS <<<\n");
out=dchols(in);
- printf("result : %f\n",out);
+ assert( (fabs(out-2) / fabs(out)) <1e-16);
}
static void dcholaTest(void){
+ /* in2 non viable car non définie positive, ne fonctionne pas dans Scilab */
double in2[49]={0.2113249,0.7560439,0.0002211,0.3303271, 0.6653811,0.6283918,0.8497452 ,\
0.6857310,0.8782165,0.0683740,0.5608486,0.6623569,0.7263507,0.1985144 ,\
0.5442573, 0.2320748 , 0.2312237, 0.2164633, 0.8833888, 0.6525135, 0.3076091 ,\
@@ -35,6 +38,8 @@ static void dcholaTest(void){
0.3321719, 0.5935095, 0.5015342 , 0.4368588 , 0.2693125 , 0.6325745 , 0.4051954 ,\
0.9184708, 0.0437334, 0.4818509 , 0.2639556 , 0.4148104 , 0.2806498 , 0.1280058 ,\
0.7783129, 0.2119030, 0.1121355 ,0.6856896 ,0.1531217 ,0.6970851 ,0.8415518 };
+
+
double in[9]= {0.722725308034569025040,0.8976796260103583335877,0.2427821881137788295746,\
0.4337721113115549087524,0.9677053210325539112091,0.5068534435704350471497,\
0.523297640960663557053,0.5596947595477104187012,0.5617307000793516635895};
@@ -68,30 +73,66 @@ static void zcholsTest(void){
static void zcholaTest(void){
- double inR[9]= {9,4,2,4,5,1,2,1,4};
- double inI[9]= {1,-1,2,-1,-4,1,2,1,4};
- double resR[9]= {3,0,0,1.333333333333333259319,\
- 1.763834207376393736766,0,0.6666666666666666296592,\
- 0.1889822365046136265487,1.7525491637693282331867};
- double resI[9]= {0,0,0,- 0.3333333333333333148296,\
- 0,0,0.6666666666666666296592,- 0.0629940788348712366052,0};
- doubleComplex *in, *out;
- int i;
+
+ {
+ double inR[9]= {9,4,2,4,5,1,2,1,4};
+ double inI[9]= {1,-1,2,-1,-4,1,2,1,4};
+ double resR[9]= {3,0,0,1.333333333333333259319,\
+ 1.763834207376393736766,0,0.6666666666666666296592,\
+ 0.1889822365046136265487,1.7525491637693282331867};
+ double resI[9]= {0,0,0,- 0.3333333333333333148296,\
+ 0,0,0.6666666666666666296592,- 0.0629940788348712366052,0};
+ doubleComplex *in, out[9];
+ int i;
+
+ printf("\n >>> ZCholA Test1 <<<\n");
+ in=DoubleComplexMatrix(inR,inI,9);
+
+ zchola(in,3,out);
+ for (i=0;i<9;i++) printf("indice : %d out : %f+%f *i\n",i,zreals(out[i]),zimags(out[i]));
+ for (i=0;i<9;i++){
+ if (zreals(out[i])>1e-16)
+ assert( (fabs(zreals(out[i])-resR[i]) / fabs(zreals(out[i]))) <1e-15);
+ if (zimags(out[i])>1e-16)
+ assert( (fabs(zimags(out[i])-resI[i]) / fabs(zimags(out[i]))) <1e-15);
+ }
+ free(in);
+ }
- printf("\n >>> ZCholA <<<\n");
- in=DoubleComplexMatrix(inR,inI,9);
- out=malloc((uint)9*sizeof(doubleComplex));
+ {
+ double inR[9]= {1.90865864663256012967,0.9230693052910239337905,1.7121882610664511670251,
+ 0.9230693052910239337905,1.6572668858351540244200,0.8330281942607563605563,
+ 1.7121882610664511670251,0.8330281942607563605563,1.6029756354175805910245};
+ double inI[9]= {0.0000000000000001301043,- 0.0097963300301950190230,- 0.2359069351837047023857,
+ 0.0097963300301950190230,0,- 0.0909413002461877950644,
+ 0.2359069351837046468745,0.0909413002461877811866,0.0000000000000000034694};
+ double resR[9]= {1.381542126260564051776 ,0,0,
+ 0.6681441613289825776079,1.1003635695246982706408 ,0,
+ 1.239331199911254843826,0.0034220321368758992685,0.1941496531533084546339 };
+ double resI[9]= {0,0,0,
+ 0.0070908659562273776769,0,0,
+ 0.1707562373231691910114,- 0.0130507331536391171789,0};
+
+ doubleComplex *in, out[9];
+ int i;
- zchola(in,3,out);
- for (i=0;i<9;i++) printf("indice : %d out : %f+%f *i\n",i,zreals(out[i]),zimags(out[i]));
- for (i=0;i<9;i++){
- if (zreals(out[i])>1e-16)
- assert( (fabs(zreals(out[i])-resR[i]) / fabs(zreals(out[i]))) <1e-15);
- if (zimags(out[i])>1e-16)
- assert( (fabs(zimags(out[i])-resI[i]) / fabs(zimags(out[i]))) <1e-15);
+ printf("\n >>> ZCholA Test2 <<<\n");
+ in=DoubleComplexMatrix(inR,inI,9);
+
+ zchola(in,3,out);
+
+ for (i=0;i<9;i++){
+ if (zreals(out[i])>1e-16)
+ assert( (fabs(zreals(out[i])-resR[i]) / fabs(zreals(out[i]))) <1e-14);
+ if (zimags(out[i])>1e-16)
+ assert( (fabs(zimags(out[i])-resI[i]) / fabs(zimags(out[i]))) <1e-16);
+ }
+ free(in);
}
- free(out);
+
+
+
}
diff --git a/src/matrixOperations/chol/zchola.c b/src/matrixOperations/chol/zchola.c
index ce6543ff..83661dc5 100644
--- a/src/matrixOperations/chol/zchola.c
+++ b/src/matrixOperations/chol/zchola.c
@@ -10,7 +10,7 @@
*
*/
-#ifdef WITHOUT_LAPACK
+#ifndef WITHOUT_LAPACK
#include "lapack.h"
#else
#include "multiplication.h"
@@ -29,7 +29,7 @@ void zchola(doubleComplex * in, int size, doubleComplex *out){
param out : output upper triangular matrix
*/
-#ifdef WITHOUT_LAPACK
+#ifndef WITHOUT_LAPACK
int i=0, j=0, info=0;
for(i=0;i<size*size;i++) out[i]=in[i];
@@ -65,6 +65,14 @@ void zchola(doubleComplex * in, int size, doubleComplex *out){
tmp = DoubleComplex(zreals(in[i*size+i])-accu,0);
out[i*size+i]=zsqrts(tmp);
}
+
+ /*Zeros in the lower triangular part*/
+ for (i=0;i<size;i++){
+ for (j=i+1;j<size;j++){
+ out[j+i*size]=DoubleComplex(0,0);
+ }
+ }
+
#endif