now editing of tasks is done in elegant way.

2 files changed, 21 insertions, 44 deletions

diff --git a/taskapp/forms/task.py b/taskapp/forms/task.py
index e0cc050..5ed21e5 100644
--- a/taskapp/forms/task.py
+++ b/taskapp/forms/task.py
@@ -22,37 +22,28 @@ class TaskCreateForm(forms.ModelForm):
 
         return data
 
-def EditTaskForm(task, instance=None):
-    class myForm(forms.ModelForm):
-        class Meta:
-            model = Task
-            fields = ['title', 'desc', 'tags_field', 'credits']
+class EditTaskForm(forms.ModelForm):
+    class Meta:
+        model = Task
+        fields = ['title', 'desc', 'tags_field', 'credits']
 
-        def clean_desc(self):
-            data = self.cleaned_data['desc'].strip()
-            if not data:
-                raise forms.ValidationError("Enter some description for the task")
+    def clean_desc(self):
+        data = self.cleaned_data['desc'].strip()
+        if not data:
+            raise forms.ValidationError("Enter some description for the task")
 
-            return data
+        return data
 
-        def clean_title(self):
-            data = self.cleaned_data['title'].strip()
-            try:
-                prev_task = Task.objects.exclude(status="DL").get(title__iexact=data)
-                if prev_task != task:
-                    raise forms.ValidationError("Another task with same title exists")
-                else:
-                    return data
-            except:
+    def clean_title(self):
+        data = self.cleaned_data['title'].strip()
+        try:
+            prev_task = Task.objects.exclude(status="DL").get(title__iexact=data)
+            if prev_task.id != self.instance.id:
+                raise forms.ValidationError("Another task with same title exists")
+            else:
                 return data
-
-    data = {
-        'title': task.title,
-        'desc': task.desc,
-        'tags_field': task.tags_field,
-        'credits': task.credits,
-    }
-    return myForm(instance) if instance else myForm(data)
+        except Task.DoesNotExist:
+            return data
 
 def AddMentorForm(choices,instance=None):
     """ return a form object with appropriate choices """
diff --git a/taskapp/views/task.py b/taskapp/views/task.py
index aadaa4b..195d98e 100644
--- a/taskapp/views/task.py
+++ b/taskapp/views/task.py
@@ -530,25 +530,12 @@ def edit_task(request, tid):
     can_edit = True if is_mentor and task.status == "UP" else False
 
     if can_edit:
-        form = EditTaskForm(task)
+        form = EditTaskForm(instance=task)
         if request.method=="POST":
             data = request.POST
-            form = EditTaskForm(task, data)
+            form = EditTaskForm(data, instance=task)
             if form.is_valid():
-                data = form.cleaned_data
-                title = data['title']
-                try:
-                    prev_task = Task.objects.exclude(status="DL").get(title__iexact=title)
-                    if prev_task != task:
-                        error_msg = "Another task exists with the same title"
-                        return render_to_response('task/edittask.html',{'user':user, 'form':form, 'error_msg':error_msg})
-                except Task.DoesNotExist:
-                    pass
-                task.title = title
-                task.desc = data['desc']
-                task.tags_field = data['tags_field']
-                task.credits = data['credits']
-                task.save()
+                form.save()
                 return redirect(task_url)
             else:
                 return render_to_response('task/edittask.html',{'user':user, 'form':form})
@@ -634,7 +621,6 @@ def close_task(request, tid):
     else:
         return show_msg(user, "You are not authorised to do this", task_url, "view the task")
 
-
 def delete_task(request, tid):
     """ mark the task status as DL.
     take a reason from the user and pass on to all the other mentors.