diff options
author | Tristan Gingold | 2014-01-27 20:24:45 +0100 |
---|---|---|
committer | Tristan Gingold | 2014-01-27 20:24:45 +0100 |
commit | 51d115c72b13507fa3e182f387651dc4aff98b5f (patch) | |
tree | 1e3eae1b98eb12767dea00eee6d066fcd8f47f59 | |
parent | f74185d729e80fb2073375a6c4c39081209e914f (diff) | |
download | ghdl-51d115c72b13507fa3e182f387651dc4aff98b5f.tar.gz ghdl-51d115c72b13507fa3e182f387651dc4aff98b5f.tar.bz2 ghdl-51d115c72b13507fa3e182f387651dc4aff98b5f.zip |
oread: add a little bit of type inference to simplify .on files.
-rw-r--r-- | ortho/debug/ortho_debug-disp.adb | 116 | ||||
-rw-r--r-- | ortho/debug/ortho_debug.adb | 9 | ||||
-rw-r--r-- | ortho/debug/ortho_debug.private.ads | 5 | ||||
-rw-r--r-- | ortho/oread/ortho_front.adb | 238 |
4 files changed, 205 insertions, 163 deletions
diff --git a/ortho/debug/ortho_debug-disp.adb b/ortho/debug/ortho_debug-disp.adb index b2779a3..ebaf3e9 100644 --- a/ortho/debug/ortho_debug-disp.adb +++ b/ortho/debug/ortho_debug-disp.adb @@ -17,6 +17,8 @@ -- 02111-1307, USA. package body Ortho_Debug.Disp is + Disp_All_Types : constant Boolean := False; + package Formated_Output is use Interfaces.C_Streams; @@ -231,7 +233,7 @@ package body Ortho_Debug.Disp is Formated_Output.Init_Context (File); end Init_Context; - procedure Disp_Enode (E : O_Enode); + procedure Disp_Enode (E : O_Enode; Etype : O_Tnode); procedure Disp_Lnode (Node : O_Lnode); procedure Disp_Snode (First, Last : O_Snode); procedure Disp_Dnode (Decl : O_Dnode); @@ -390,7 +392,7 @@ package body Ortho_Debug.Disp is Put ("("); if El /= null then loop - Disp_Enode (El.Actual); + Disp_Enode (El.Actual, El.Formal.Dtype); El := El.Next; exit when El = null; Put (", "); @@ -410,9 +412,10 @@ package body Ortho_Debug.Disp is end if; end Image; - procedure Disp_Lit (Lit_Type : O_Tnode; Str : String) is + -- Disp STR as a literal for scalar type LIT_TYPE. + procedure Disp_Lit (Lit_Type : O_Tnode; Known : Boolean; Str : String) is begin - if False then + if Known and not Disp_All_Types then Put_Trim (Str); else Disp_Tnode_Name (Lit_Type); @@ -422,8 +425,18 @@ package body Ortho_Debug.Disp is end if; end Disp_Lit; - procedure Disp_Cnode (C : O_Cnode) is + -- Display C. If CTYPE is set, this is the known type of C. + procedure Disp_Cnode (C : O_Cnode; Ctype : O_Tnode) + is + Known : constant Boolean := Ctype /= O_Tnode_Null; begin + -- Sanity check. + if Known then + if Ctype /= C.Ctype then + raise Program_Error; + end if; + end if; + case C.Kind is when OC_Unsigned_Lit => if False and then (C.U_Val >= Character'Pos(' ') @@ -433,18 +446,21 @@ package body Ortho_Debug.Disp is Put (Character'Val (C.U_Val)); Put ('''); else - Disp_Lit (C.Ctype, Unsigned_64'Image (C.U_Val)); + Disp_Lit (C.Ctype, Known, Unsigned_64'Image (C.U_Val)); end if; when OC_Signed_Lit => - Disp_Lit (C.Ctype, Integer_64'Image (C.S_Val)); + Disp_Lit (C.Ctype, Known, Integer_64'Image (C.S_Val)); when OC_Float_Lit => - Disp_Lit (C.Ctype, IEEE_Float_64'Image (C.F_Val)); + Disp_Lit (C.Ctype, Known, IEEE_Float_64'Image (C.F_Val)); when OC_Boolean_Lit => - Disp_Lit (C.Ctype, Get_String (C.B_Id)); + -- Always disp the type of boolean literals. + Disp_Lit (C.Ctype, False, Get_String (C.B_Id)); when OC_Null_Lit => - Disp_Lit (C.Ctype, "null"); + -- Always disp the type of null literals. + Disp_Lit (C.Ctype, False, "null"); when OC_Enum_Lit => - Disp_Lit (C.Ctype, Get_String (C.E_Name)); + -- Always disp the type of enum literals. + Disp_Lit (C.Ctype, False, Get_String (C.E_Name)); when OC_Sizeof_Lit => Disp_Tnode_Name (C.Ctype); Put ("'sizeof ("); @@ -465,25 +481,34 @@ package body Ortho_Debug.Disp is when OC_Aggregate => declare El : O_Cnode; + El_Type : O_Tnode; Field : O_Fnode; begin Put ('{'); El := C.Aggr_Els; - if C.Ctype.Kind = ON_Record_Type then - Field := C.Ctype.Elements; - else - Field := null; - end if; + case C.Ctype.Kind is + when ON_Record_Type => + Field := C.Ctype.Elements; + El_Type := Field.Ftype; + when ON_Array_Sub_Type => + Field := null; + El_Type := C.Ctype.Base_Type.El_Type; + when others => + raise Program_Error; + end case; if El /= null then loop Set_Mark; if Field /= null then - Put ('.'); - Disp_Ident (Field.Ident); - Put (" = "); + if Disp_All_Types then + Put ('.'); + Disp_Ident (Field.Ident); + Put (" = "); + end if; + El_Type := Field.Ftype; Field := Field.Next; end if; - Disp_Cnode (El.Aggr_Value); + Disp_Cnode (El.Aggr_Value, El_Type); El := El.Aggr_Next; exit when El = null; Put (", "); @@ -492,13 +517,13 @@ package body Ortho_Debug.Disp is Put ('}'); end; when OC_Aggr_Element => - Disp_Cnode (C.Aggr_Value); + Disp_Cnode (C.Aggr_Value, Ctype); when OC_Union_Aggr => Put ('{'); Put ('.'); Disp_Ident (C.Uaggr_Field.Ident); Put (" = "); - Disp_Cnode (C.Uaggr_Value); + Disp_Cnode (C.Uaggr_Value, C.Uaggr_Field.Ftype); Put ('}'); when OC_Address => Disp_Tnode_Name (C.Ctype); @@ -518,35 +543,36 @@ package body Ortho_Debug.Disp is end case; end Disp_Cnode; - procedure Disp_Enode (E : O_Enode) + -- Disp E whose expected type is ETYPE (may not be set). + procedure Disp_Enode (E : O_Enode; Etype : O_Tnode) is begin case E.Kind is when OE_Lit => - Disp_Cnode (E.Lit); + Disp_Cnode (E.Lit, Etype); when OE_Dyadic_Expr_Kind => Put ("("); - Disp_Enode (E.Left); + Disp_Enode (E.Left, O_Tnode_Null); Put (' '); Disp_Enode_Name (E.Kind); Put (' '); - Disp_Enode (E.Right); + Disp_Enode (E.Right, E.Left.Rtype); Put (')'); when OE_Compare_Expr_Kind => Disp_Tnode_Name (E.Rtype); Put ("'("); - Disp_Enode (E.Left); + Disp_Enode (E.Left, O_Tnode_Null); Put (' '); Disp_Enode_Name (E.Kind); Put (' '); - Disp_Enode (E.Right); + Disp_Enode (E.Right, E.Left.Rtype); Put (')'); when OE_Monadic_Expr_Kind => Disp_Enode_Name (E.Kind); if E.Kind /= OE_Neg_Ov then Put (' '); end if; - Disp_Enode (E.Operand); + Disp_Enode (E.Operand, Etype); when OE_Address => Disp_Tnode_Name (E.Rtype); Put ("'address ("); @@ -560,7 +586,7 @@ package body Ortho_Debug.Disp is when OE_Convert_Ov => Disp_Tnode_Name (E.Rtype); Put ("'conv ("); - Disp_Enode (E.Conv); + Disp_Enode (E.Conv, O_Tnode_Null); Put (')'); when OE_Function_Call => Disp_Dnode_Name (E.Func); @@ -569,7 +595,7 @@ package body Ortho_Debug.Disp is when OE_Alloca => Disp_Tnode_Name (E.Rtype); Put ("'alloca ("); - Disp_Enode (E.A_Size); + Disp_Enode (E.A_Size, O_Tnode_Null); Put (')'); when OE_Value => Disp_Lnode (E.Value); @@ -584,17 +610,17 @@ package body Ortho_Debug.Disp is when OL_Obj => Disp_Dnode_Name (Node.Obj); when OL_Access_Element => - Disp_Enode (Node.Acc_Base); + Disp_Enode (Node.Acc_Base, O_Tnode_Null); Put (".all"); when OL_Indexed_Element => Disp_Lnode (Node.Array_Base); Put ('['); - Disp_Enode (Node.Index); + Disp_Enode (Node.Index, O_Tnode_Null); Put (']'); when OL_Slice => Disp_Lnode (Node.Slice_Base); Put ('['); - Disp_Enode (Node.Slice_Index); + Disp_Enode (Node.Slice_Index, O_Tnode_Null); Put ("...]"); when OL_Selected_Element => Disp_Lnode (Node.Rec_Base); @@ -685,7 +711,7 @@ package body Ortho_Debug.Disp is Put ("subarray "); Disp_Tnode_Name (Atype.Base_Type); Put ("["); - Disp_Cnode (Atype.Length); + Disp_Cnode (Atype.Length, Atype.Base_Type.Index_Type); Put ("]"); end case; end Disp_Tnode; @@ -792,7 +818,7 @@ package body Ortho_Debug.Disp is Put ("constant "); Disp_Ident (Decl.Name); Put (" := "); - Disp_Cnode (Decl.Value); + Disp_Cnode (Decl.Value, Decl.Dtype); Put_Line (";"); when ON_Var_Decl => Disp_Storage_Name (Decl.Storage); @@ -851,12 +877,12 @@ package body Ortho_Debug.Disp is when ON_Assign_Stmt => Disp_Lnode (Stmt.Target); Put (" := "); - Disp_Enode (Stmt.Value); + Disp_Enode (Stmt.Value, Stmt.Target.Rtype); Put_Line (";"); when ON_Return_Stmt => Put ("return "); if Stmt.Ret_Val /= null then - Disp_Enode (Stmt.Ret_Val); + Disp_Enode (Stmt.Ret_Val, O_Tnode_Null); end if; Put_Line (";"); when ON_If_Stmt => @@ -875,7 +901,7 @@ package body Ortho_Debug.Disp is else Put ("elsif "); end if; - Disp_Enode (Stmt.Cond); + Disp_Enode (Stmt.Cond, O_Tnode_Null); Put_Line (" then"); end if; Add_Tab; @@ -897,7 +923,7 @@ package body Ortho_Debug.Disp is Put_Line (";"); when ON_Case_Stmt => Put ("case "); - Disp_Enode (Stmt.Selector); + Disp_Enode (Stmt.Selector, O_Tnode_Null); Put_Line (" is"); Add_Tab; Disp_Snode (Stmt.Next, Stmt.Case_Last); @@ -907,6 +933,8 @@ package body Ortho_Debug.Disp is when ON_When_Stmt => declare Choice: O_Choice; + Choice_Type : constant O_Tnode := + Stmt.Branch_Parent.Selector.Rtype; begin Rem_Tab; Choice := Stmt.Choice_List; @@ -914,11 +942,11 @@ package body Ortho_Debug.Disp is Put ("when "); case Choice.Kind is when ON_Choice_Expr => - Disp_Cnode (Choice.Expr); + Disp_Cnode (Choice.Expr, Choice_Type); when ON_Choice_Range => - Disp_Cnode (Choice.Low); + Disp_Cnode (Choice.Low, Choice_Type); Put (" ... "); - Disp_Cnode (Choice.High); + Disp_Cnode (Choice.High, Choice_Type); when ON_Choice_Default => Put ("default"); end case; @@ -970,7 +998,7 @@ package body Ortho_Debug.Disp is Ctx : Disp_Context; begin Push_Context (Interfaces.C_Streams.stdout, Ctx); - Disp_Enode (N); + Disp_Enode (N, O_Tnode_Null); Put (" : "); Disp_Tnode_Decl (N.Rtype); Pop_Context (Ctx); diff --git a/ortho/debug/ortho_debug.adb b/ortho/debug/ortho_debug.adb index ba02904..a1ef7b8 100644 --- a/ortho/debug/ortho_debug.adb +++ b/ortho/debug/ortho_debug.adb @@ -1583,9 +1583,10 @@ package body Ortho_Debug is N : O_Anode; begin Check_Type (Assocs.Interfaces.Dtype, Val.Rtype); - Assocs.Interfaces := Assocs.Interfaces.Next; Check_Ref (Val); - N := new O_Anode_Type'(Next => null, Formal => null, Actual => Val); + N := new O_Anode_Type'(Next => null, + Formal => Assocs.Interfaces, Actual => Val); + Assocs.Interfaces := Assocs.Interfaces.Next; if Assocs.Last = null then Assocs.First := N; else @@ -1753,7 +1754,6 @@ package body Ortho_Debug is procedure Start_Case_Stmt (Block : in out O_Case_Block; Value : O_Enode) is - pragma Unreferenced (Block); subtype O_Snode_Case_Type is O_Snode_Type (ON_Case_Stmt); N : O_Snode; begin @@ -1773,6 +1773,7 @@ package body Ortho_Debug is Case_Last => null, Selector => Value, Branches => null); + Block.Case_Stmt := N; Add_Stmt (N); Push_Stmt_Scope (new Stmt_Case_Scope_Type'(Kind => Stmt_Case, Parent => N, @@ -1784,7 +1785,6 @@ package body Ortho_Debug is procedure Start_Choice (Block : in out O_Case_Block) is - pragma Unreferenced (Block); N : O_Snode; begin if Current_Stmt_Scope.Kind /= Stmt_Case then @@ -1800,6 +1800,7 @@ package body Ortho_Debug is N.all := O_Snode_Type'(Kind => ON_When_Stmt, Next => null, Lineno => 0, + Branch_Parent => Block.Case_Stmt, Choice_List => null, Next_Branch => null); if Current_Stmt_Scope.Last_Branch = null then diff --git a/ortho/debug/ortho_debug.private.ads b/ortho/debug/ortho_debug.private.ads index 20bcae2..09d9b4c 100644 --- a/ortho/debug/ortho_debug.private.ads +++ b/ortho/debug/ortho_debug.private.ads @@ -390,9 +390,12 @@ private Loop_Id : O_Snode; when ON_Case_Stmt => Selector : O_Enode; + -- Simply linked list of branches Branches : O_Snode; Case_Last : O_Snode; when ON_When_Stmt => + -- The corresponding 'case' + Branch_Parent : O_Snode; Choice_List : O_Choice; Next_Branch : O_Snode; when ON_Call_Stmt => @@ -443,7 +446,7 @@ private Last : O_Cnode; end record; type O_Case_Block is record - null; + Case_Stmt : O_Snode; end record; type O_If_Block is record diff --git a/ortho/oread/ortho_front.adb b/ortho/oread/ortho_front.adb index 2b82fd8..626241a 100644 --- a/ortho/oread/ortho_front.adb +++ b/ortho/oread/ortho_front.adb @@ -1201,8 +1201,9 @@ package body Ortho_Front is -- procedure Parse_Declaration; - function Parse_Unary_Expression (Atype : Node_Acc) return O_Enode; - function Parse_Expression (Expr_Type : Node_Acc) return O_Enode; + procedure Parse_Expression (Expr_Type : Node_Acc; + Expr : out O_Enode; + Res_Type : out Node_Acc); procedure Parse_Name (Prefix : Node_Acc; Name : out O_Lnode; N_Type : out Node_Acc); procedure Parse_Lvalue (N : in out O_Lnode; N_Type : in out Node_Acc); @@ -1282,6 +1283,7 @@ package body Ortho_Front is return Res; end Parse_Alignof; + -- Parse a literal whose type is ATYPE. function Parse_Typed_Literal (Atype : Node_Acc) return O_Cnode is Res : O_Cnode; @@ -1395,12 +1397,12 @@ package body Ortho_Front is end Parse_Typed_Literal; -- expect: next token - function Parse_Named_Expression - (Atype : Node_Acc; Name : Node_Acc; Stop_At_All : Boolean) - return O_Enode + -- Parse an expression starting with NAME. + procedure Parse_Named_Expression + (Atype : Node_Acc; Name : Node_Acc; Stop_At_All : Boolean; + Res : out O_Enode; + Res_Type : out Node_Acc) is - Res : O_Enode; - R_Type : Node_Acc; begin if Tok = Tok_Tick then Next_Token; @@ -1408,55 +1410,59 @@ package body Ortho_Front is -- Typed literal. Next_Token; Res := New_Lit (Parse_Typed_Literal (Name.Decl_Dtype)); + Res_Type := Name.Decl_Dtype; Expect (Tok_Right_Brack); Next_Token; - return Res; elsif Tok = Tok_Left_Paren then - -- Typed expression. + -- Typed expression (used for comparaison operators) Next_Token; - Res := Parse_Expression (Name.Decl_Dtype); + Parse_Expression (Name.Decl_Dtype, Res, Res_Type); Expect (Tok_Right_Paren); Next_Token; - return Res; elsif Tok = Tok_Ident then -- Attribute. if Token_Sym = Id_Conv then Next_Expect (Tok_Left_Paren); Next_Token; - Res := Parse_Expression (null); + Parse_Expression (null, Res, Res_Type); + -- Discard Res_Type. Expect (Tok_Right_Paren); Next_Token; - R_Type := Name.Decl_Dtype; - Res := New_Convert_Ov (Res, R_Type.Type_Onode); + Res_Type := Name.Decl_Dtype; + Res := New_Convert_Ov (Res, Res_Type.Type_Onode); -- Fall-through. elsif Token_Sym = Id_Address or Token_Sym = Id_Unchecked_Address or Token_Sym = Id_Subprg_Addr then - R_Type := Name.Decl_Dtype; + Res_Type := Name.Decl_Dtype; Res := Parse_Address (Name); -- Fall-through. elsif Token_Sym = Id_Sizeof then - Res := New_Lit (Parse_Sizeof (Name.Decl_Dtype)); + Res_Type := Name.Decl_Dtype; + Res := New_Lit (Parse_Sizeof (Res_Type)); Next_Token; - return Res; + return; elsif Token_Sym = Id_Alignof then - Res := New_Lit (Parse_Alignof (Name.Decl_Dtype)); + Res_Type := Name.Decl_Dtype; + Res := New_Lit (Parse_Alignof (Res_Type)); Next_Token; - return Res; + return; elsif Token_Sym = Id_Alloca then Next_Expect (Tok_Left_Paren); Next_Token; - Res := New_Alloca - (Name.Decl_Dtype.Type_Onode, - Parse_Expression (null)); + Parse_Expression (null, Res, Res_Type); + -- Discard Res_Type. + Res_Type := Name.Decl_Dtype; + Res := New_Alloca (Res_Type.Type_Onode, Res); Expect (Tok_Right_Paren); Next_Token; - return Res; + return; elsif Token_Sym = Id_Offsetof then - Res := New_Lit (Parse_Offsetof (Atype)); + Res_Type := Atype; + Res := New_Lit (Parse_Offsetof (Res_Type)); Next_Token; - return Res; + return; else Parse_Error ("unknown attribute name"); end if; @@ -1473,7 +1479,7 @@ package body Ortho_Front is begin Parse_Association (Constr, Name); Res := New_Function_Call (Constr); - R_Type := Name.Decl_Dtype; + Res_Type := Name.Decl_Dtype; -- Fall-through. end; elsif Name.Kind = Node_Object @@ -1482,10 +1488,9 @@ package body Ortho_Front is -- Name. declare Lval : O_Lnode; - L_Type : Node_Acc; begin - Parse_Name (Name, Lval, L_Type); - return New_Value (Lval); + Parse_Name (Name, Lval, Res_Type); + Res := New_Value (Lval); end; else Parse_Error ("bad ident expression: " @@ -1496,11 +1501,11 @@ package body Ortho_Front is -- R_TYPE and RES must be set. if Tok = Tok_Dot then if Stop_At_All then - return Res; + return; end if; Next_Token; if Tok = Tok_All then - if R_Type.Kind /= Type_Access then + if Res_Type.Kind /= Type_Access then Parse_Error ("type of prefix is not an access"); end if; declare @@ -1508,101 +1513,69 @@ package body Ortho_Front is begin Next_Token; N := New_Access_Element (Res); - R_Type := R_Type.Access_Dtype; - Parse_Lvalue (N, R_Type); + Res_Type := Res_Type.Access_Dtype; + Parse_Lvalue (N, Res_Type); Res := New_Value (N); end; - return Res; + return; else Parse_Error ("'.all' expected"); end if; - else - return Res; end if; end Parse_Named_Expression; - function Parse_Primary_Expression (Atype : Node_Acc) return O_Enode + procedure Parse_Primary_Expression (Atype : Node_Acc; + Res : out O_Enode; + Res_Type : out Node_Acc) is - Res : O_Enode; begin case Tok is when Tok_Num | Tok_Float_Num => - return New_Lit (Parse_Typed_Literal (Atype)); + if Atype = null then + Parse_Error ("numeric literal without type context"); + end if; + Res_Type := Atype; + Res := New_Lit (Parse_Typed_Literal (Atype)); when Tok_Ident => declare N : Node_Acc; begin N := Get_Decl (Token_Sym); Next_Token; - return Parse_Named_Expression (Atype, N, False); + Parse_Named_Expression (Atype, N, False, Res, Res_Type); end; when Tok_Left_Paren => Next_Token; - Res := Parse_Expression (Atype); + Parse_Expression (Atype, Res, Res_Type); Expect (Tok_Right_Paren); Next_Token; - return Res; --- when Tok_Ident => --- declare --- Inter : Node_Acc; --- begin --- Inter := Token_Sym.Inter; --- while Inter /= null loop --- case Inter.Kind is --- when Inter_Var --- | Inter_Param => --- Res := New_Value (Inter.Object_Node); --- Next_Token; --- return Res; --- when Inter_Subprg => --- return Parse_Function_Call (Inter); --- when Inter_Keyword => --- raise Program_Error; --- end case; --- Inter := Inter.Next; --- end loop; --- Parse_Error ("undefined name " & Get_String (Token_Sym.Ident)); --- return O_Enode_Null; --- end; when others => Parse_Error ("bad primary expression: " & Token_Type'Image (Tok)); - return O_Enode_Null; end case; end Parse_Primary_Expression; - function Parse_Unary_Expression (Atype : Node_Acc) return O_Enode + -- Parse '-' EXPR, 'not' EXPR, 'abs' EXPR or EXPR. + procedure Parse_Unary_Expression (Atype : Node_Acc; + Res : out O_Enode; + Res_Type : out Node_Acc) is - Operand : O_Enode; begin case Tok is when Tok_Minus => Next_Token; - case Tok is --- when Tok_Float_Num => --- Operand := New_Float_Literal (Atype.Type_Onode, --- -Token_Float); --- Next_Token; --- return Operand; --- when Tok_Num => --- Operand := New_Signed_Literal (Atype.Type_Onode, --- -Integer_64 (Token_Number)); --- Next_Token; --- return Operand; - when others => - Operand := Parse_Primary_Expression (Atype); - return New_Monadic_Op (ON_Neg_Ov, Operand); - end case; + Parse_Primary_Expression (Atype, Res, Res_Type); + Res := New_Monadic_Op (ON_Neg_Ov, Res); when Tok_Not => Next_Token; - Operand := Parse_Unary_Expression (Atype); - return New_Monadic_Op (ON_Not, Operand); + Parse_Unary_Expression (Atype, Res, Res_Type); + Res := New_Monadic_Op (ON_Not, Res); when Tok_Abs => Next_Token; - Operand := Parse_Unary_Expression (Atype); - return New_Monadic_Op (ON_Abs_Ov, Operand); + Parse_Unary_Expression (Atype, Res, Res_Type); + Res := New_Monadic_Op (ON_Abs_Ov, Res); when others => - return Parse_Primary_Expression (Atype); + Parse_Primary_Expression (Atype, Res, Res_Type); end case; end Parse_Unary_Expression; @@ -1613,13 +1586,23 @@ package body Ortho_Front is return Op_Ov; end Check_Sharp; - function Parse_Expression (Expr_Type : Node_Acc) return O_Enode + procedure Parse_Expression (Expr_Type : Node_Acc; + Expr : out O_Enode; + Res_Type : out Node_Acc) is + Op_Type : Node_Acc; L : O_Enode; R : O_Enode; Op : ON_Op_Kind; begin - L := Parse_Unary_Expression (Expr_Type); + if Expr_Type = null or else Expr_Type.Kind = Type_Boolean then + -- The type of the expression isn't known, as this can be a + -- comparaison operator. + Op_Type := null; + else + Op_Type := Expr_Type; + end if; + Parse_Unary_Expression (Op_Type, L, Res_Type); case Tok is when Tok_Div => Op := Check_Sharp (ON_Div_Ov); @@ -1658,18 +1641,23 @@ package body Ortho_Front is Next_Token; when others => - return L; + Expr := L; + return; end case; if Op in ON_Compare_Op_Kind then Next_Token; end if; - R := Parse_Unary_Expression (Expr_Type); + Parse_Unary_Expression (Res_Type, R, Res_Type); case Op is when ON_Dyadic_Op_Kind => - return New_Dyadic_Op (Op, L, R); + Expr := New_Dyadic_Op (Op, L, R); when ON_Compare_Op_Kind => - return New_Compare_Op (Op, L, R, Expr_Type.Type_Onode); + if Expr_Type = null then + Parse_Error ("comparaison operator requires a type"); + end if; + Expr := New_Compare_Op (Op, L, R, Expr_Type.Type_Onode); + Res_Type := Expr_Type; when others => raise Program_Error; end case; @@ -1712,6 +1700,7 @@ package body Ortho_Front is declare V : O_Enode; Bt : Node_Acc; + Res_Type : Node_Acc; begin Next_Token; if N_Type.Kind = Type_Subarray then @@ -1722,7 +1711,7 @@ package body Ortho_Front is if Bt.Kind /= Type_Array then Parse_Error ("type of prefix is not an array"); end if; - V := Parse_Expression (Bt.Array_Index); + Parse_Expression (Bt.Array_Index, V, Res_Type); if Tok = Tok_Elipsis then N := New_Slice (N, Bt.Type_Onode, V); Next_Token; @@ -1754,8 +1743,10 @@ package body Ortho_Front is declare Val : O_Enode; begin - Val := Parse_Named_Expression (null, Prefix, True); - N_Type := Prefix.Decl_Dtype; + Parse_Named_Expression (null, Prefix, True, Val, N_Type); + if N_Type /= Prefix.Decl_Dtype then + Parse_Error ("type doesn't match"); + end if; if Tok = Tok_Dot then Next_Token; if Tok = Tok_All then @@ -1783,6 +1774,8 @@ package body Ortho_Front is procedure Parse_Association (Constr : in out O_Assoc_List; Decl : Node_Acc) is Param : Node_Acc; + Expr : O_Enode; + Expr_Type : Node_Acc; begin Start_Association (Constr, Decl.Subprg_Node); if Tok /= Tok_Left_Paren then @@ -1794,7 +1787,8 @@ package body Ortho_Front is if Param = null then Parse_Error ("too many parameters"); end if; - New_Association (Constr, Parse_Expression (Param.Decl_Dtype)); + Parse_Expression (Param.Decl_Dtype, Expr, Expr_Type); + New_Association (Constr, Expr); Param := Param.Param_Next; exit when Tok /= Tok_Comma; Next_Token; @@ -1880,9 +1874,12 @@ package body Ortho_Front is when Tok_If => declare If_Blk : O_If_Block; + Cond : O_Enode; + Cond_Type : Node_Acc; begin Next_Token; - Start_If_Stmt (If_Blk, Parse_Expression (null)); + Parse_Expression (null, Cond, Cond_Type); + Start_If_Stmt (If_Blk, Cond); Expect (Tok_Then); Next_Token; Parse_Statements; @@ -1947,16 +1944,22 @@ package body Ortho_Front is end; when Tok_Return => - Next_Token; - if Tok /= Tok_Semicolon then - New_Return_Stmt (Parse_Expression (Current_Subprg.Decl_Dtype)); + declare + Res : O_Enode; + Res_Type : Node_Acc; + begin + Next_Token; if Tok /= Tok_Semicolon then - Parse_Error ("';' expected at end of return statement"); + Parse_Expression (Current_Subprg.Decl_Dtype, Res, Res_Type); + New_Return_Stmt (Res); + if Tok /= Tok_Semicolon then + Parse_Error ("';' expected at end of return statement"); + end if; + else + New_Return_Stmt; end if; - else - New_Return_Stmt; - end if; - Next_Token; + Next_Token; + end; when Tok_Ident => -- This is either a procedure call or an assignment. @@ -1982,6 +1985,8 @@ package body Ortho_Front is -- An assignment. declare Name : O_Lnode; + Expr : O_Enode; + Expr_Type : Node_Acc; N_Type : Node_Acc; begin Parse_Name (Inter, Name, N_Type); @@ -1989,7 +1994,8 @@ package body Ortho_Front is Parse_Error ("`:=' expected after a variable"); end if; Next_Token; - New_Assign_Stmt (Name, Parse_Expression (N_Type)); + Parse_Expression (N_Type, Expr, Expr_Type); + New_Assign_Stmt (Name, Expr); if Tok /= Tok_Semicolon then Parse_Error ("';' expected at end of assignment"); end if; @@ -2003,9 +2009,12 @@ package body Ortho_Front is declare Case_Blk : O_Case_Block; L : O_Cnode; + Choice : O_Enode; + Choice_Type : Node_Acc; begin Next_Token; - Start_Case_Stmt (Case_Blk, Parse_Expression (null)); + Parse_Expression (null, Choice, Choice_Type); + Start_Case_Stmt (Case_Blk, Choice); Expect (Tok_Is); Next_Token; loop @@ -2367,13 +2376,14 @@ package body Ortho_Front is Start_Record_Aggr (Constr, Atype.Type_Onode); Field := Atype.Record_Union_Fields; while Field /= null loop - Expect (Tok_Dot); - Next_Expect (Tok_Ident); - if Token_Sym /= Field.Field_Ident then - Parse_Error ("bad field name"); + if Tok = Tok_Dot then + Next_Expect (Tok_Ident); + if Token_Sym /= Field.Field_Ident then + Parse_Error ("bad field name"); + end if; + Next_Expect (Tok_Equal); + Next_Token; end if; - Next_Expect (Tok_Equal); - Next_Token; New_Record_Aggr_El (Constr, Parse_Constant_Value (Field.Field_Type)); Field := Field.Field_Next; |