summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Swithinbank2023-07-15 10:21:21 +0200
committerGitHub2023-07-15 10:21:21 +0200
commitd618678b1901c621e1c8d2dc1a34ee299582b14e (patch)
tree33e371f7e5a929b098f780cbbff7194e9b1d6666
parent01f5476786883373a40ad60330df88d43a6bf867 (diff)
downloadIT.starlight-d618678b1901c621e1c8d2dc1a34ee299582b14e.tar.gz
IT.starlight-d618678b1901c621e1c8d2dc1a34ee299582b14e.tar.bz2
IT.starlight-d618678b1901c621e1c8d2dc1a34ee299582b14e.zip
Fix logo/CSS non-relative path escaping (#343)
-rw-r--r--.changeset/cold-windows-swim.md5
-rw-r--r--docs/astro.config.mjs4
-rw-r--r--packages/starlight/index.ts2
3 files changed, 8 insertions, 3 deletions
diff --git a/.changeset/cold-windows-swim.md b/.changeset/cold-windows-swim.md
new file mode 100644
index 00000000..fa6aeae0
--- /dev/null
+++ b/.changeset/cold-windows-swim.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/starlight": patch
+---
+
+Fix escaping of non-relative user config file paths for custom CSS and logos
diff --git a/docs/astro.config.mjs b/docs/astro.config.mjs
index 752b28a9..907f0b44 100644
--- a/docs/astro.config.mjs
+++ b/docs/astro.config.mjs
@@ -18,8 +18,8 @@ export default defineConfig({
starlight({
title: 'Starlight',
logo: {
- light: './src/assets/logo-light.svg',
- dark: './src/assets/logo-dark.svg',
+ light: '/src/assets/logo-light.svg',
+ dark: '/src/assets/logo-dark.svg',
replacesTitle: true,
},
editLink: {
diff --git a/packages/starlight/index.ts b/packages/starlight/index.ts
index 8a46b29f..80d3b630 100644
--- a/packages/starlight/index.ts
+++ b/packages/starlight/index.ts
@@ -89,7 +89,7 @@ function vitePluginStarlightUserConfig(
{ root }: AstroConfig
): NonNullable<ViteUserConfig['plugins']>[number] {
const resolveRelativeId = (id: string) =>
- id.startsWith('.') ? JSON.stringify(resolve(fileURLToPath(root), id)) : id;
+ JSON.stringify(id.startsWith('.') ? resolve(fileURLToPath(root), id) : id);
const modules = {
'virtual:starlight/user-config': `export default ${JSON.stringify(opts)}`,
'virtual:starlight/project-context': `export default ${JSON.stringify({