summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Swithinbank2024-09-02 14:46:47 +0200
committerGitHub2024-09-02 14:46:47 +0200
commit746e0cd301f4ac4a182e8c45b36865c61d208b77 (patch)
tree968e4495a1716a8a623c98820622cbf1cd880529
parent239262a7a3e6af07055f0bacf1061f8e0ae89f48 (diff)
downloadIT.starlight-746e0cd301f4ac4a182e8c45b36865c61d208b77.tar.gz
IT.starlight-746e0cd301f4ac4a182e8c45b36865c61d208b77.tar.bz2
IT.starlight-746e0cd301f4ac4a182e8c45b36865c61d208b77.zip
Fixes type error with Astro 4.15.x (#2273)
-rw-r--r--.changeset/fifty-gorillas-study.md5
-rw-r--r--packages/starlight/__tests__/basics/i18n.test.ts2
-rw-r--r--packages/starlight/utils/i18n.ts3
3 files changed, 9 insertions, 1 deletions
diff --git a/.changeset/fifty-gorillas-study.md b/.changeset/fifty-gorillas-study.md
new file mode 100644
index 00000000..eb4bf249
--- /dev/null
+++ b/.changeset/fifty-gorillas-study.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/starlight': patch
+---
+
+Fixes type error when using Starlight with Astro v4.15
diff --git a/packages/starlight/__tests__/basics/i18n.test.ts b/packages/starlight/__tests__/basics/i18n.test.ts
index 32dd299a..7c0af56a 100644
--- a/packages/starlight/__tests__/basics/i18n.test.ts
+++ b/packages/starlight/__tests__/basics/i18n.test.ts
@@ -303,7 +303,7 @@ function getAstroI18nTestConfig(i18nConfig: AstroUserConfig['i18n']): AstroConfi
...i18nConfig,
routing:
typeof i18nConfig?.routing !== 'string'
- ? { prefixDefaultLocale: false, ...i18nConfig?.routing }
+ ? { prefixDefaultLocale: false, fallbackType: 'redirect', ...i18nConfig?.routing }
: i18nConfig.routing,
} as AstroConfig['i18n'];
}
diff --git a/packages/starlight/utils/i18n.ts b/packages/starlight/utils/i18n.ts
index 5ec66722..6c9816d0 100644
--- a/packages/starlight/utils/i18n.ts
+++ b/packages/starlight/utils/i18n.ts
@@ -70,6 +70,9 @@ function getAstroI18nConfig(config: StarlightConfig): NonNullable<AstroConfig['i
// Sites with a single non-root language different from the built-in default locale.
(!config.isMultilingual && config.locales !== undefined),
redirectToDefaultLocale: false,
+ // TODO: remove this ignore comment for Astro v5
+ // @ts-ignore — Only used in Astro >=4.15.0, but Starlight supports ^4.8.6
+ fallbackType: 'redirect',
},
};
}