summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Swithinbank2024-01-19 14:39:46 +0100
committerGitHub2024-01-19 14:39:46 +0100
commit0163634abb8578ce7a3d7ceea36432e98ea70e78 (patch)
tree986d6ffa035cbdec63d8c79b8717a132c58c5029
parent490c6eff34ab408c4f55777b7b0caa16787dd3d4 (diff)
downloadIT.starlight-0163634abb8578ce7a3d7ceea36432e98ea70e78.tar.gz
IT.starlight-0163634abb8578ce7a3d7ceea36432e98ea70e78.tar.bz2
IT.starlight-0163634abb8578ce7a3d7ceea36432e98ea70e78.zip
Restore original tighter line-height on `<LinkCard>` titles (#1386)
-rw-r--r--.changeset/eighty-cats-float.md13
-rw-r--r--packages/starlight/user-components/LinkCard.astro10
2 files changed, 18 insertions, 5 deletions
diff --git a/.changeset/eighty-cats-float.md b/.changeset/eighty-cats-float.md
new file mode 100644
index 00000000..3a94a9d6
--- /dev/null
+++ b/.changeset/eighty-cats-float.md
@@ -0,0 +1,13 @@
+---
+'@astrojs/starlight': minor
+---
+
+Tightens `line-height` on `<LinkCard>` titles to fix regression from original design
+
+If you want to preserve the previous `line-height`, you can add the following custom CSS to your site:
+
+```css
+.sl-link-card a {
+ line-height: 1.6;
+}
+```
diff --git a/packages/starlight/user-components/LinkCard.astro b/packages/starlight/user-components/LinkCard.astro
index aecbe572..8cf6fbd9 100644
--- a/packages/starlight/user-components/LinkCard.astro
+++ b/packages/starlight/user-components/LinkCard.astro
@@ -10,7 +10,7 @@ interface Props extends Omit<HTMLAttributes<'a'>, 'title'> {
const { title, description, ...attributes } = Astro.props;
---
-<div>
+<div class="sl-link-card">
<span class="sl-flex stack">
<a {...attributes}>
<span class="title" set:html={title} />
@@ -21,7 +21,7 @@ const { title, description, ...attributes } = Astro.props;
</div>
<style>
- div {
+ .sl-link-card {
display: grid;
grid-template-columns: 1fr auto;
gap: 0.5rem;
@@ -34,6 +34,7 @@ const { title, description, ...attributes } = Astro.props;
a {
text-decoration: none;
+ line-height: var(--sl-line-height-headings);
}
/* a11y fix for https://github.com/withastro/starlight/issues/487 */
@@ -52,7 +53,6 @@ const { title, description, ...attributes } = Astro.props;
color: var(--sl-color-white);
font-weight: 600;
font-size: var(--sl-text-lg);
- line-height: var(--sl-line-height-headings);
}
.description {
@@ -65,12 +65,12 @@ const { title, description, ...attributes } = Astro.props;
}
/* Hover state */
- div:hover {
+ .sl-link-card:hover {
background: var(--sl-color-gray-7, var(--sl-color-gray-6));
border-color: var(--sl-color-gray-2);
}
- div:hover .icon {
+ .sl-link-card:hover .icon {
color: var(--sl-color-white);
}
</style>