From 92128185b5d278b3a248f1f5eb8b824947febbce Mon Sep 17 00:00:00 2001
From: ankitjavalkar
Date: Wed, 8 Nov 2017 19:48:33 +0530
Subject: - Add command to stop the container before removing it - Fix README
 based on feedback

---
 README.md | 12 +++++++++---
 tasks.py  |  1 +
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 8c2d6d1..bc47792 100644
--- a/README.md
+++ b/README.md
@@ -47,11 +47,17 @@ Quick Start
 
     - Install the dependencies
 
+        - For Python 2 use:
+
+            $ pip install -r ./requirements/requirements-py2.txt
+
+        - For Python 3 (recommended) use:
+
             $ pip install -r ./requirements/requirements-py3.txt
 
 #### Short instructions
 
-1. To see a quick demo after installing yaksh do the following:
+1. To run the application do the following:
 
         $ invoke serve
 
@@ -59,14 +65,14 @@ Quick Start
 
     - To run the code server in a sandboxed docker environment, run the command:
 
-        $ invoke start
+            $ invoke start
 
     - Make sure that you have docker installed on your system beforehand
 
 
     - To run the code server without docker, locally use:
 
-        $ invoke start --unsafe
+            $ invoke start --unsafe
 
     - Note this command will run the yaksh code server locally on your machine
       and is susceptible to malicious code.
diff --git a/tasks.py b/tasks.py
index 29adb60..4e41ed5 100644
--- a/tasks.py
+++ b/tasks.py
@@ -85,6 +85,7 @@ def stop(ctx, container=TARGET_CONTAINER_NAME, hide=True):
     result = ctx.run("sudo docker ps -q --filter='name={0}'".format(container))
     if result.stdout:
         print ("** Discarding the docker container <{0}>".format(container))
+        ctx.run("sudo docker stop {0}".format(container))
         ctx.run("sudo docker rm {0}".format(container))
     else:
         print("** Docker container <{0}> not found **".format(container))
-- 
cgit