Add filters: Minor fixes

1 files changed, 10 insertions, 32 deletions

diff --git a/testapp/exam/static/exam/js/question_filter.js b/testapp/exam/static/exam/js/question_filter.js
index 7dc92a6..065b06b 100644
--- a/testapp/exam/static/exam/js/question_filter.js
+++ b/testapp/exam/static/exam/js/question_filter.js
@@ -3,7 +3,7 @@ $(document).ready(function(){
     $marks = $("#id_marks");
     $language = $("#id_language");
 
-    $question_type.change(function() {
+    function question_filter() {
         $.ajax({
             url: "/exam/ajax/questions/filter/",
             type: "POST",
@@ -18,51 +18,29 @@ $(document).ready(function(){
                 $("#filtered-questions").html(questions);
             }
         });
+    }
+
+    $question_type.change(function() {
+        question_filter()
     });
 
     $language.change(function() {
-        $.ajax({
-            url: "/exam/ajax/questions/filter/",
-            type: "POST",
-            data: {
-                question_type: $question_type.val(),
-                marks: $marks.val(),
-                language: $language.val()
-            },
-            dataType: "html",
-            success: function(output) {
-                var questions = $(output).filter("#questions").html();
-                $("#filtered-questions").html(questions);
-            }
-        });
+        question_filter()
     });
 
     $marks.change(function() {
-        $.ajax({
-            url: "/exam/ajax/questions/filter/",
-            type: "POST",
-            data: {
-                question_type: $question_type.val(),
-                marks: $marks.val(),
-                language: $language.val()
-            },
-            dataType: "html",
-            success: function(output) {
-                var questions = $(output).filter("#questions").html();
-                $("#filtered-questions").html(questions);
-            }
-        });
+        question_filter()
     });
 
     $("#checkall").live("click", function(){
         if($(this).attr("checked")) {
                 $("#filtered-questions input:checkbox").each(function(index, element) {
-                $(this).attr('checked','checked');
+                $(this).attr('checked', true);
                 });
         }
         else {
-                $("#filtered_questions input:checkbox").each(function(index, element) {
-                $(this).removeAttr('checked');
+                $("#filtered-questions input:checkbox").each(function(index, element) {
+                $(this).attr('checked', false);
                 });
         }
     });