Fix design question paper UI

5 files changed, 275 insertions, 233 deletions

diff --git a/yaksh/static/yaksh/css/question_paper_creation.css b/yaksh/static/yaksh/css/question_paper_creation.css
index ff4bf32..bc8feeb 100644
--- a/yaksh/static/yaksh/css/question_paper_creation.css
+++ b/yaksh/static/yaksh/css/question_paper_creation.css
@@ -1,10 +1,3 @@
-body {
-  font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
-  font-size: 13px;
-  font-weight: normal;
-  line-height: 18px;
-  color: #404040;
-}
 .nav-tabs > li.active > a, .nav-tabs > li.active > a:hover, .nav-tabs > li.active > a:focus {
     background-color: #FFFFFF;
     border-color: #DDDDDD #DDDDDD rgba(0, 0, 0, 0);
@@ -63,20 +56,20 @@ body {
 #fixed-questions .col-md-6 > div,
 #random-questions .col-md-6 > div{
     background: #f5f5f5;
-    height: 200px;
+    height: 300px;
     border: 1px solid #333333;
     padding: 5px;
 }
 #fixed-available,
 #random-available {
-    height: 125px;
-    min-height: 125px;
+    height: 220px;
+    min-height: 200px;
     overflow-y: scroll;
     margin-bottom: 15px;
 }
 #fixed-added,
 #random-added {
-    height: 160px;
+    height: 220px;
     overflow-y: scroll;
 }
 #fixed-added hr,
diff --git a/yaksh/templates/yaksh/add_quiz.html b/yaksh/templates/yaksh/add_quiz.html
index cc5a961..1e3c425 100644
--- a/yaksh/templates/yaksh/add_quiz.html
+++ b/yaksh/templates/yaksh/add_quiz.html
@@ -77,22 +77,8 @@
         <a class="btn btn-outline-info" name="button" href="{% url 'yaksh:test_quiz' 'godmode' quiz.id course_id %}" target="blank">
           God Mode
         </a>
-      <a data-toggle="collapse" data-target="#help">
-      <span class=" text-info"><i class="fa fa-info-circle"></i> Help</span></a>
-      <div id="help" class="collapse">
-        <br>
-        <div class="card border-primary">
-          <div class="card-body">
-              <b>User Mode:</b> Attempt quiz the way normal users will attempt i.e. -
-              <ul class="list-group list-group-flush">
-                <li class="list-group-item">Quiz will have the same duration as that of the original quiz.</li>
-                <li class="list-group-item">Quiz won't start if the course is inactive or the quiz time has expired.</li>
-                <li class="list-group-item">You will be notified about quiz prerequisites.(You can still attempt the quiz though)</li>
-              </ul>
-              <b>God Mode:</b> Attempt quiz without any time or eligibilty constraints.
-            </div>
-        </div>
-      </div>
+      <a data-toggle="modal" data-target="#help">
+      <span class="text-info"><i class="fa fa-info-circle"></i> Help</span></a>
       {% endif %}
   {% endif %}
   <style type="text/css">
@@ -101,4 +87,27 @@
      }
   </style>
 </div>
+<div class="modal" id="help">
+  <div class="modal-dialog" role="document">
+    <div class="modal-content">
+      <div class="modal-header">
+        <h5 class="modal-title">Quiz Test Modes</h5>
+        <button type="button" class="close" data-dismiss="modal" aria-label="Close">
+          <span aria-hidden="true"><i class="fa fa-close"></i></span>
+        </button>
+      </div>
+      <div class="modal-body">
+        <p>
+          <b>User Mode:</b> Attempt quiz the way normal users will attempt i.e. -
+              <ul class="list-group list-group-flush">
+                <li class="list-group-item">Quiz will have the same duration as that of the original quiz.</li>
+                <li class="list-group-item">Quiz won't start if the course is inactive or the quiz time has expired.</li>
+                <li class="list-group-item">You will be notified about quiz prerequisites.(You can still attempt the quiz though)</li>
+              </ul>
+          <b>God Mode:</b> Attempt quiz without any time or eligibilty constraints.
+        </p>
+      </div>
+    </div>
+  </div>
+</div>
 {% endblock %}
diff --git a/yaksh/templates/yaksh/design_questionpaper.html b/yaksh/templates/yaksh/design_questionpaper.html
index 0ab7cc0..c5aa25e 100644
--- a/yaksh/templates/yaksh/design_questionpaper.html
+++ b/yaksh/templates/yaksh/design_questionpaper.html
@@ -1,39 +1,36 @@
 {% extends "manage.html" %}
+{% load static %}
 
 {% block title %} Design Question Paper {% endblock title %}
 
 {% block subtitle %} Design Question Paper {% endblock %}
 
 {% block css %}
-    <link rel="stylesheet" media="all" type="text/css" href="{{ URL_ROOT }}/static/yaksh/css/question_paper_creation.css" />
-<style>
-select
-{
-    width:auto;
-}
-</style>
+    <link rel="stylesheet" media="all" type="text/css" href="{% static 'yaksh/css/question_paper_creation.css' %}" />
 {% endblock %}
 
 {% block script %}
-    <script src="{{ URL_ROOT }}/static/yaksh/js/jquery-3.3.1.min.js"></script>
-    <script src="{{ URL_ROOT }}/static/yaksh/js/jquery-ui.js"></script>
-    <script src="{{ URL_ROOT }}/static/yaksh/js/bootstrap.min.js"></script>
-    <script src="{{ URL_ROOT }}/static/yaksh/js/question_paper_creation.js"></script>
+    <script src="{% static 'yaksh/js/jquery-ui.js' %}"></script>
+    <script src="{% static 'yaksh/js/question_paper_creation.js' %}"></script>
 {% endblock %}
 
 {% block content %}
-<div class="yakshwell container">
+<div class="container">
 <input type=hidden id="url_root" value={{ URL_ROOT }}>
 {% if course_id %}
-    <form action="{{ URL_ROOT }}/exam/manage/designquestionpaper/{{ qpaper.quiz.id }}/{{ qpaper.id }}/{{course_id}}/" method="POST" id="design_q">
-    <a href="{{URL_ROOT}}/exam/manage/courses" class="btn btn-danger">Cancel</a>
+    <form action="{% url 'yaksh:designquestionpaper' qpaper.quiz.id qpaper.id course_id %}" method="POST" id="design_q">
+    <a href="{% url 'yaksh:get_course_modules' course_id %}" class="btn btn-primary">
+        <i class="fa fa-arrow-left"></i>&nbsp;Back
+    </a>
 {% else %}
-    <form action="{{ URL_ROOT }}/exam/manage/designquestionpaper/{{ qpaper.quiz.id }}/{{ qpaper.id }}/" method="POST" id="design_q">
-    <a href="{{URL_ROOT}}/exam/manage/courses/all_quizzes" class="btn btn-danger">Cancel</a>
+    <form action="{% url 'yaksh:designquestionpaper' qpaper.quiz.id qpaper.id %}" method="POST" id="design_q">
+    <a href="{% url 'yaksh:show_all_quizzes' %}" class="btn btn-danger">
+        <i class="fa fa-arrow-left"></i>&nbsp;Back
+    </a>
 {% endif %}
     {% csrf_token %}
     <input type=hidden name="is_active" id="is_active" value="{{ state }}">
-<center><b>Manual mode to design the {{lang}}  Question Paper</center><br>
+    <center><b>Manual mode to design the {{lang}}  Question Paper</center><br>
     <div class = "tab-base">
         <ul class="nav nav-pills tabs">
         <li id="fixed-tab">
@@ -55,86 +52,105 @@ select
         </a></li>
     </ul>
     </div>
+    <br>
     <div>
-        <h3>Total Marks:  <span id="total_marks" class="well"> {{ qpaper.total_marks }} </span></h3>
+        <h3>Total Marks:
+            <span id="total_marks" class="well"> {{ qpaper.total_marks }}</span>
+        </h3>
     </div>
-<div class="tab-content">
-    <!-- common to fixed and random questions -->
-    <div class="row" id="selectors">
-        <div class = "col-md-8">
-            <h5>Please select Question type and Marks</h5>
+    <br>
+    {% if messages %}
+        {% for message in messages %}
+        <div class="alert alert-dismissible alert-{{ message.tags }}">
+            <button type="button" class="close" data-dismiss="alert">
+                <i class="fa fa-close"></i>
+            </button>
+            <strong>{{ message }}</strong>
         </div>
-        <div class="col-md-6">
-            {{ filter_form.question_type }}
-        </div>
-        <div class="col-md-6">
-            {{ filter_form.marks }}
-        </div>
-    </div> <!-- /.row -->
-    <br><br>
-    {% csrf_token %}
-    <div class="tab-pane active" id="fixed-questions">
-        <h4>Or</h4>
-        <!-- Search questions using tags -->
-        <h4>Search using Tags: </h4>
-        <span class="input-group-addon" id="basic-addon1">Search Questions: </span>
-        <div class="col-md-14">
-        <div class="input-group">
-            <input type="text" id="question_tags" name="question_tags" class="form-control"
-             placeholder="Search using comma separated Tags">
-            <span class="input-group-btn">
-            <button class="btn btn-default" type="submit">Search</button>
-            </span>
+        {% endfor %}
+    {% endif %}
+    <div class="tab-content">
+        <!-- common to fixed and random questions -->
+        <div class="row" id="selectors">
+            <div class = "col-md-8">
+                <h5>Please select Question type and Marks</h5>
+            </div>
             <div class="col-md-6">
-            <select class="form-control" id="sel1" onchange="append_tag(this);">
-            {% if all_tags %}
-             <option value="" disabled selected>Available Tags</option>
-            {% for tag in all_tags %}
-            <option>
-                {{tag}}
-            </option>
-            {% endfor %}
-            {% else %}
-             <option value="" disabled selected>No Available Tags</option>
-            {% endif %}
-            </select>
+                {{ filter_form.question_type }}
             </div>
-        </div>
-        </div>
-        <br><br>
-        <div class="row">
             <div class="col-md-6">
-                <div id="fixed-available-wrapper">
-                    <p><u>Select questions to add:</u></p>
-                    <div id="fixed-available">
-                        {% if state == "fixed"  or state == "None" %}
-                            <ul class="inputs-list">
-                               {% for question in questions %}
-                                    <li>
-                                        <label>
-                                            <input type="checkbox" name="questions" data-qid="{{question.id}}" value={{question.id}}>
-                                            <span>
-                                                {% if user == question.user %}
-                                                    <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
-                                                {% else %}
-                                                    {{question.summary}}
-                                                {% endif %}
-                                            </span>
-                                            <span> {{ question.points }}</span>
-                                        </label>
-                                     </li>
-                                {% endfor %}
-                            </ul>
-                        {% endif %}
-                    </div>
-                    <br /><br />
-                    <button id="add-fixed" name="add-fixed" class="btn small btn-primary pull-right" type="submit">Add to paper</button>
+                {{ filter_form.marks }}
+            </div>
+        </div> <!-- /.row -->
+        <br>
+        {% csrf_token %}
+        <div class="tab-pane active" id="fixed-questions">
+            <h4>Or</h4>
+            <!-- Search questions using tags -->
+            <h4>Search using Tags: </h4>
+            <span class="input-group-addon" id="basic-addon1">Search Questions: </span>
+            <div class="col-md-14">
+            <div class="input-group">
+                <input type="text" id="question_tags" name="question_tags" class="form-control"
+                 placeholder="Search using comma separated Tags">
+                <span class="input-group-btn">
+                <button class="btn btn-outline-primary" type="submit">
+                    <i class="fa fa-search"></i>&nbsp;Search
+                </button>
+                </span>
+                <div class="col-md-6">
+                <select class="form-control" id="sel1" onchange="append_tag(this);">
+                {% if all_tags %}
+                 <option value="" disabled selected>Available Tags</option>
+                {% for tag in all_tags %}
+                <option>
+                    {{tag}}
+                </option>
+                {% endfor %}
+                {% else %}
+                 <option value="" disabled selected>No Available Tags</option>
+                {% endif %}
+                </select>
                 </div>
             </div>
-            <div class="col-md-6">
-                <div id="fixed-added-wrapper">
-                    <p><u>Fixed questions currently in paper:</u></p>
-                    <div id="fixed-added">
+            </div>
+            <br><br>
+            <br>
+            <div class="row">
+                <div class="col-md-6">
+                    <div id="fixed-available-wrapper">
+                        <p><u>Select questions to add:</u></p>
+                        <div id="fixed-available">
+                            {% if state == "fixed"  or state == "None" %}
+                                <ul class="inputs-list">
+                                   {% for question in questions %}
+                                        <li>
+                                            <label>
+                                                <input type="checkbox" name="questions" data-qid="{{question.id}}" value={{question.id}}>
+                                                <span>
+                                                    {% if user == question.user %}
+                                                        <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
+                                                    {% else %}
+                                                        {{question.summary}}
+                                                    {% endif %}
+                                                </span>
+                                                <span> {{ question.points }}</span>
+                                            </label>
+                                         </li>
+                                    {% endfor %}
+                                </ul>
+                            {% endif %}
+                        </div>
+                    </div>
+                    <br />
+                    <button id="add-fixed" name="add-fixed" class="btn btn-success pull-right" type="submit">
+                        <i class="fa fa-plus-square"></i>&nbsp;Add to paper
+                    </button>
+                </div>
+                <div class="col-md-6">
+                    <div id="fixed-added-wrapper">
+                        <p><u>Fixed questions currently in paper:</u></p>
+                        <div id="fixed-added">
                             <ul class="inputs-list">
                                {% for question in fixed_questions %}
                                     <li>
@@ -153,119 +169,125 @@ select
                                      </li>
                                 {% endfor %}
                             </ul>
+                        </div>
                     </div>
-                     <br />
-                    <button id="remove-fixed" name="remove-fixed" class="btn btn-danger pull-right" type="submit"> Remove from paper</button>
+                    <br />
+                    <button id="remove-fixed" name="remove-fixed" class="btn btn-danger pull-right" type="submit">
+                        <i class="fa fa-minus-square"></i>&nbsp;Remove from paper
+                    </button>
                 </div>
+            </div> <!-- /.row -->
+            <br>
+            <div class="pull-right">
+                <a class="btn btn-info" id="fixed-next">Next &gt;</a>
             </div>
-        </div> <!-- /.row -->
-        <br>
-        <div class="pull-right">
-            <a class="btn btn-info" id="fixed-next">Next &gt;</a>
-        </div>
-    </div> <!-- /#fixed-questions -->
+        </div> <!-- /#fixed-questions -->
 
-    <div class="tab-pane" id="random-questions">
-        <div class="row">
-            <div class="col-md-6">
-                <div id="random-available-wrapper">
-                    <p><u>Select questions to add to the pool:</u></p>
-                    <div id="random-available">
-                        {% if state == "random" %}
-                            <select id="num_of_questions" name="num_of_questions">
-                                <option value="1">Number of questions to be picked from the pool</option>
-                                    {% for q in questions %}
-                                        {% if forloop.counter0 != 0 %}
-                                             <option value={{forloop.counter0}}>{{ forloop.counter0}}</option>
+        <div class="tab-pane" id="random-questions">
+            <div class="row">
+                <div class="col-md-6">
+                    <div id="random-available-wrapper">
+                        <p><u>Select questions to add to the pool:</u></p>
+                        <div id="random-available">
+                            {% if state == "random" %}
+                                <select id="num_of_questions" name="num_of_questions">
+                                    <option value="1">Number of questions to be picked from the pool</option>
+                                        {% for q in questions %}
+                                            {% if forloop.counter0 != 0 %}
+                                                 <option value={{forloop.counter0}}>{{ forloop.counter0}}</option>
+                                                 {% endif %}
+                                             {% if questions|length == 1%}
+                                                 <option value=1>1</option>
                                              {% endif %}
-                                         {% if questions|length == 1%}
-                                             <option value=1>1</option>
-                                         {% endif %}
+                                        {% endfor %}
+                                </select>
+                                <ul class="inputs-list">
+                                   {% for question in questions %}
+                                        <li>
+                                            <label>
+                                                <input type="checkbox" name="random_questions" data-qid="{{question.id}}" value={{question.id}}>
+                                                <span>
+                                                    {% if user == question.user %}
+                                                        <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
+                                                    {% else %}
+                                                        {{question.summary}}
+                                                    {% endif %}</span>
+                                                <span> {{ question.points }} </span>
+                                            </label>
+                                         </li>
                                     {% endfor %}
-                            </select>
-                            <ul class="inputs-list">
-                               {% for question in questions %}
-                                    <li>
-                                        <label>
-                                            <input type="checkbox" name="random_questions" data-qid="{{question.id}}" value={{question.id}}>
-                                            <span>
-                                                {% if user == question.user %}
-                                                    <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
-                                                {% else %}
-                                                    {{question.summary}}
-                                                {% endif %}</span>
-                                            <span> {{ question.points }} </span>
-                                        </label>
-                                     </li>
-                                {% endfor %}
-                            </ul>
-                        {% endif %}
+                                </ul>
+                            {% endif %}
+                        </div>
                     </div>
-                    <br /><br />
-                    <button id="add-random" name="add-random" class="btn btn-primary pull-right" type="submit">Add to paper</button>
+                    <br>
+                    <button id="add-random" name="add-random" class="btn btn-success pull-right" type="submit">
+                        <i class="fa fa-plus-square"></i>&nbsp;Add to paper
+                    </button>
                 </div>
-            </div>
-            <div class="col-md-6">
-                <div id="random-added-wrapper">
-                    <p><u>Pool of  questions currently in paper:</u></p>
-                    <div id="random-added">
-                            <ul class="inputs-list">
-                                {% for random_set in random_sets %}
-                                        <li>
-                                        <label>
-                                            <input type="checkbox" name="random_sets" data-qid="{{random_set.id}}" value={{random_set.id}}>
-                                            <span> Random Set {{ forloop.counter }}  (will take {{ random_set.num_questions }} randomly out of  {{ random_set.questions.count }})</span>
-                                        </label>
-                                        </li>
-                                    {% for question in random_set.questions.all %}
-                                        <li>
-                                        <label>
-                                            <span>
-                                                {% if user == question.user %}
-                                                    <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
-                                                {% else %}
-                                                    {{question.summary}}
-                                                {% endif %}</span>
-                                            <span> {{ question.points }} </span>
-                                        </label>
-                                        </li>
+                <div class="col-md-6">
+                    <div id="random-added-wrapper">
+                        <p><u>Pool of  questions currently in paper:</u></p>
+                        <div id="random-added">
+                                <ul class="inputs-list">
+                                    {% for random_set in random_sets %}
+                                            <li>
+                                            <label>
+                                                <input type="checkbox" name="random_sets" data-qid="{{random_set.id}}" value={{random_set.id}}>
+                                                <span> Random Set {{ forloop.counter }}  (will take {{ random_set.num_questions }} randomly out of  {{ random_set.questions.count }})</span>
+                                            </label>
+                                            </li>
+                                        {% for question in random_set.questions.all %}
+                                            <li>
+                                            <label>
+                                                <span>
+                                                    {% if user == question.user %}
+                                                        <a href="{{URL_ROOT}}/exam/manage/addquestion/{{ question.id }}" target="_blank">{{ question.summary }}</a>
+                                                    {% else %}
+                                                        {{question.summary}}
+                                                    {% endif %}</span>
+                                                <span> {{ question.points }} </span>
+                                            </label>
+                                            </li>
+                                        {% endfor %}
                                     {% endfor %}
-                                {% endfor %}
-                            </ul>
+                                </ul>
+                        </div>
                     </div>
                     <br />
-                    <button id="remove-random" name="remove-random" class="btn btn-danger pull-right" type="submit"> Remove from paper</button>
+                    <button id="remove-random" name="remove-random" class="btn btn-danger pull-right" type="submit">
+                        <i class="fa fa-minus-square"></i>&nbsp;Remove from paper
+                    </button>
                 </div>
-            </div>
-        </div> <!-- /.row -->
-        <br>
-        <div class="pull-left">
-            <a class="btn btn-info" id="random-prev">&lt; Previous</a>
-        </div>
-        <div class="pull-right">
-            <a class="btn btn-info" id="random-next">Next &gt;</a>
-        </div>
-   </div> <!-- /#random-questions -->
-
-    <div class="tab-pane" id="finish">
-        <center>
-            <h5><u>Almost finished creating your question paper</u></h5>
-            <label style="float: none;">
-                {{ qpaper_form.shuffle_questions }}
-                <span>Shuffle questions' order for each student</span>
-            </label> <br><br>
-            <label style="float: none;">
-                {{ qpaper_form.shuffle_testcases }}
-                <span>Shuffle MCQ/MCC options for each student</span>
-            </label> <br><br>
-            <input class ="btn btn-success" type="submit" name="save" id="save" value="Save question paper">
+            </div> <!-- /.row -->
             <br>
             <div class="pull-left">
-                <a class="btn btn-info" id="finish-prev">&lt; Previous</a>
+                <a class="btn btn-info" id="random-prev">&lt; Previous</a>
             </div>
-       </center>
-    </div> <!-- /#finish -->
-</div>
+            <div class="pull-right">
+                <a class="btn btn-info" id="random-next">Next &gt;</a>
+            </div>
+       </div> <!-- /#random-questions -->
+
+        <div class="tab-pane" id="finish">
+            <center>
+                <h5><u>Almost finished creating your question paper</u></h5>
+                <label style="float: none;">
+                    {{ qpaper_form.shuffle_questions }}
+                    <span>Shuffle questions' order for each student</span>
+                </label> <br><br>
+                <label style="float: none;">
+                    {{ qpaper_form.shuffle_testcases }}
+                    <span>Shuffle MCQ/MCC options for each student</span>
+                </label> <br><br>
+                <input class="btn btn-success btn-lg" type="submit" name="save" id="save" value="Save">
+                <br>
+                <div class="pull-left">
+                    <a class="btn btn-info" id="finish-prev">&lt; Previous</a>
+                </div>
+           </center>
+        </div> <!-- /#finish -->
+    </div>
 <!-- /.tab-content -->
 </form>
 <br>
diff --git a/yaksh/templates/yaksh/moderator_dashboard.html b/yaksh/templates/yaksh/moderator_dashboard.html
index e9a6985..af1f546 100644
--- a/yaksh/templates/yaksh/moderator_dashboard.html
+++ b/yaksh/templates/yaksh/moderator_dashboard.html
@@ -19,16 +19,16 @@
         <a href="{% url 'yaksh:create_demo_course' %}" class="btn btn-primary btn-lg">
             Create Demo Course
         </a>
-        <br>
-        {% if msg %}
-        <div class="container">
-            <div class="alert alert-dismissible alert-info">
+        <br><br>
+        {% if messages %}
+            {% for message in messages %}
+            <div class="alert alert-dismissible alert-{{ message.tags }}">
                 <button type="button" class="close" data-dismiss="alert">
                     <i class="fa fa-close"></i>
                 </button>
-                <strong>{{ msg }}</strong>
+                <strong>{{ message }}</strong>
             </div>
-        </div>
+            {% endfor %}
         {% endif %}
     </center>
     {% with objects as courses %}
diff --git a/yaksh/views.py b/yaksh/views.py
index 9c2a0df..b9d94c5 100644
--- a/yaksh/views.py
+++ b/yaksh/views.py
@@ -407,7 +407,7 @@ def prof_manage(request, msg=None):
     except EmptyPage:
         # If page is out of range (e.g. 9999), deliver last page of results.
         courses = paginator.page(paginator.num_pages)
-
+    messages.info(request, msg)
     context = {'user': user, 'objects': courses}
     return my_render_to_response(
         request, 'yaksh/moderator_dashboard.html', context
@@ -1413,19 +1413,26 @@ def design_questionpaper(request, quiz_id, questionpaper_id=None,
                 question_paper.fixed_question_order = questions_order
                 question_paper.save()
                 question_paper.fixed_questions.add(*questions)
+                messages.success(request, "Questions added successfully")
+            else:
+                messages.warning(request, "Please select atleast one question")
 
         if 'remove-fixed' in request.POST:
             question_ids = request.POST.getlist('added-questions', None)
-            if question_paper.fixed_question_order:
-                que_order = question_paper.fixed_question_order.split(",")
-                for qid in question_ids:
-                    que_order.remove(qid)
-                if que_order:
-                    question_paper.fixed_question_order = ",".join(que_order)
-                else:
-                    question_paper.fixed_question_order = ""
-                question_paper.save()
-            question_paper.fixed_questions.remove(*question_ids)
+            if question_ids:
+                if question_paper.fixed_question_order:
+                    que_order = question_paper.fixed_question_order.split(",")
+                    for qid in question_ids:
+                        que_order.remove(qid)
+                    if que_order:
+                        question_paper.fixed_question_order = ",".join(que_order)
+                    else:
+                        question_paper.fixed_question_order = ""
+                    question_paper.save()
+                question_paper.fixed_questions.remove(*question_ids)
+                messages.success(request, "Questions removed successfully")
+            else:
+                messages.warning(request, "Please select atleast one question")
 
         if 'add-random' in request.POST:
             question_ids = request.POST.getlist('random_questions', None)
@@ -1437,14 +1444,21 @@ def design_questionpaper(request, quiz_id, questionpaper_id=None,
                 random_ques = Question.objects.filter(id__in=question_ids)
                 random_set.questions.add(*random_ques)
                 question_paper.random_questions.add(random_set)
+                messages.success(request, "Questions removed successfully")
+            else:
+                messages.warning(request, "Please select atleast one question")
 
         if 'remove-random' in request.POST:
             random_set_ids = request.POST.getlist('random_sets', None)
-            question_paper.random_questions.remove(*random_set_ids)
+            if random_set_ids:
+                question_paper.random_questions.remove(*random_set_ids)
+                messages.success(request, "Questions removed successfully")
+            else:
+                messages.warning(request,"Please select question set")
 
         if 'save' in request.POST or 'back' in request.POST:
             qpaper_form.save()
-            return my_redirect('/exam/manage/courses/all_quizzes/')
+            messages.success(request, "Question Paper saved successfully")
 
         if marks:
             questions = _get_questions(user, question_type, marks)
@@ -1956,6 +1970,10 @@ def test_quiz(request, mode, quiz_id, course_id=None):
     current_user = request.user
     quiz = Quiz.objects.get(id=quiz_id)
     if (quiz.is_expired() or not quiz.active) and not godmode:
+        messages.warning(
+            request,
+            "{0} is either expired or inactive".format(quiz.description)
+        )
         return my_redirect('/exam/manage')
 
     trial_questionpaper, trial_course, trial_module = test_mode(