From e0003f3fc2b49d52a647281af3695b386ec7d8bf Mon Sep 17 00:00:00 2001 From: trondeau Date: Wed, 5 Aug 2009 01:36:09 +0000 Subject: Fixed optfir for producing equiripple FIR filters. Does LPF, fixes the HPF, and adds BPF (real). git-svn-id: http://gnuradio.org/svn/gnuradio/trunk@11537 221aa14e-8319-0410-a670-987f0aec2ac5 --- gnuradio-core/src/lib/general/gr_remez.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'gnuradio-core/src/lib/general') diff --git a/gnuradio-core/src/lib/general/gr_remez.cc b/gnuradio-core/src/lib/general/gr_remez.cc index ca6df541b..86c2901b5 100644 --- a/gnuradio-core/src/lib/general/gr_remez.cc +++ b/gnuradio-core/src/lib/general/gr_remez.cc @@ -814,8 +814,10 @@ gr_remez (int order, if (arg_bands[0] < 0 || arg_bands[arg_bands.size () - 1] > 1) punt ("gr_remez: band edges must be in the range [0,1]"); + // Divide by 2 to fit with the implementation that uses a + // sample rate of [0, 0.5] instead of [0, 1.0] for (int i = 0; i < 2 * numbands; i++) - bands[i] = arg_bands[i] / 2; // FIXME why / 2? + bands[i] = arg_bands[i] / 2; LOCAL_BUFFER (double, response, numbands * 2); if (arg_response.size () != arg_bands.size ()) -- cgit