From d618678b1901c621e1c8d2dc1a34ee299582b14e Mon Sep 17 00:00:00 2001 From: Chris Swithinbank Date: Sat, 15 Jul 2023 10:21:21 +0200 Subject: Fix logo/CSS non-relative path escaping (#343) --- .changeset/cold-windows-swim.md | 5 +++++ docs/astro.config.mjs | 4 ++-- packages/starlight/index.ts | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/cold-windows-swim.md diff --git a/.changeset/cold-windows-swim.md b/.changeset/cold-windows-swim.md new file mode 100644 index 00000000..fa6aeae0 --- /dev/null +++ b/.changeset/cold-windows-swim.md @@ -0,0 +1,5 @@ +--- +"@astrojs/starlight": patch +--- + +Fix escaping of non-relative user config file paths for custom CSS and logos diff --git a/docs/astro.config.mjs b/docs/astro.config.mjs index 752b28a9..907f0b44 100644 --- a/docs/astro.config.mjs +++ b/docs/astro.config.mjs @@ -18,8 +18,8 @@ export default defineConfig({ starlight({ title: 'Starlight', logo: { - light: './src/assets/logo-light.svg', - dark: './src/assets/logo-dark.svg', + light: '/src/assets/logo-light.svg', + dark: '/src/assets/logo-dark.svg', replacesTitle: true, }, editLink: { diff --git a/packages/starlight/index.ts b/packages/starlight/index.ts index 8a46b29f..80d3b630 100644 --- a/packages/starlight/index.ts +++ b/packages/starlight/index.ts @@ -89,7 +89,7 @@ function vitePluginStarlightUserConfig( { root }: AstroConfig ): NonNullable[number] { const resolveRelativeId = (id: string) => - id.startsWith('.') ? JSON.stringify(resolve(fileURLToPath(root), id)) : id; + JSON.stringify(id.startsWith('.') ? resolve(fileURLToPath(root), id) : id); const modules = { 'virtual:starlight/user-config': `export default ${JSON.stringify(opts)}`, 'virtual:starlight/project-context': `export default ${JSON.stringify({ -- cgit